Include Java versions 21, 22, 23, 24 in CI #1987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathmesh-stripe
requested review from
xavdid-stripe
and removed request for
a team
Member
xavdid-stripe
left a comment
xavdid-stripe
left a comment
There was a problem hiding this comment.
I think it makes sense to add these because they're all current. But we probably don't need them long term. Basically all of our users are on LTS java versions (8, 11, 17, and 21).
Given that, in this PR, I'd also:
- drop any older non-LTS versions we're currently testing
- add a link to the java version support list so future readers know why we're testing
- add a comment to codify which versions we should include in this list and why
xavdid-stripe
approved these changes
Apr 15, 2025
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In order to keep supporting new versions of Java we need to test against them.
What?
Added Java versions 21, 22, 23, 24 to our CI workflow.
See Also